updated according to dbt-teradata 1.8.2 #6577

tallamohan · 2024-12-03T09:33:08Z

What are you changing in this pull request and why?

Updated the setup and config pages of dbt-teradata according to the latest release dbt-teradata 1.8.2

vercel · 2024-12-03T09:33:12Z

@tallamohan is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

website/docs/docs/core/connect-data-platform/teradata-setup.md

website/docs/reference/resource-configs/teradata-configs.md

Co-authored-by: Mirna Wong <[email protected]>

vercel · 2024-12-10T01:33:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs-getdbt-com	❌ Failed (Inspect)		Dec 10, 2024 1:38am

Co-authored-by: Mirna Wong <[email protected]>

mirnawong1 · 2024-12-13T11:46:25Z

looping in @amychen1776 as an fyi

mirnawong1 · 2024-12-13T11:46:57Z

website/docs/docs/core/connect-data-platform/teradata-setup.md

@@ -210,7 +209,8 @@ For using cross-DB macros, teradata-utils as a macro namespace will not be used,

  ##### <a name="hash"></a>hash

-  `Hash` macro needs an `md5` function implementation. Teradata doesn't support `md5` natively. You need to install a User Defined Function (UDF):
+  `Hash` macro needs an `md5` function implementation. Teradata doesn't support `md5` natively. You need to install a User Defined Function (UDF) and optionally specify `md5_udf` [variable](/docs/build/project-variables).  <br> 
+   If not specified the code defaults to using `GLOBAL_FUNCTIONS.hash_md5`. See below instructions on how to install the custom UDF:


Suggested change

If not specified the code defaults to using `GLOBAL_FUNCTIONS.hash_md5`. See below instructions on how to install the custom UDF:

If not specified the code defaults to using `GLOBAL_FUNCTIONS.hash_md5`. See the following instructions on how to install the custom UDF:

This information should be called out in the Teradata config page.

mirnawong1 · 2024-12-13T11:47:31Z

website/docs/docs/core/connect-data-platform/teradata-setup.md

@@ -241,6 +247,14 @@ dbt-teradata 1.8.0 and later versions support unit tests, enabling you to valida

 ## Limitations

+### Browser Authentication


Suggested change

### Browser Authentication

### Browser authentication

mirnawong1 · 2024-12-13T11:51:42Z

website/docs/docs/core/connect-data-platform/teradata-setup.md

@@ -241,6 +247,14 @@ dbt-teradata 1.8.0 and later versions support unit tests, enabling you to valida

 ## Limitations

+### Browser Authentication
+When running a dbt job with logmech set to "browser", the initial authentication opens a browser window where you must enter your username and password.<br>


@tallamohan can you turn these into bullets and remove the
. so:

When running a dbt job with logmech set to "browser", the initial authentication opens a browser window where you must enter your username and password.

After authentication, this window remains open, requiring you to manually switch back to the dbt console.

For every subsequent connection, a new browser tab briefly opens, displaying the message "TERADATA BROWSER AUTHENTICATION COMPLETED," and silently reuses the existing session.

However, the focus stays on the browser window, so you’ll need to manually switch back to the dbt console each time.

This behavior is the default functionality of the teradatasql driver and cannot be avoided at this time.

To prevent session expiration and the need to re-enter credentials, ensure the authentication browser window stays open until the job is complete.

mirnawong1 · 2024-12-13T11:52:20Z

website/docs/reference/resource-configs/teradata-configs.md

@@ -348,6 +348,18 @@ If a user sets some key-value pair with value as `'{model}'`, internally this `'
 - For example, if the model the user is running is `stg_orders`, `{model}` will be replaced with `stg_orders` in runtime.
 - If no `query_band` is set by the user, the default query_band used will be: ```org=teradata-internal-telem;appname=dbt;```

+## Unit testing
+* Unit testing is supported in dbt-teradata, allowing users to write and execute unit tests using the dbt test command.
+  * For detailed guidance, refer to the dbt documentation.


Suggested change

* For detailed guidance, refer to the dbt documentation.

* For detailed guidance, refer to the [dbt unit tests documentation](/docs/build/documentation).

mirnawong1 · 2024-12-13T11:53:21Z

website/docs/reference/resource-configs/teradata-configs.md

-* `history_column_in_target` &mdash; Column in the target table of **period** datatype that tracks history.
+* `unique_key`: The primary key of the model (excluding the valid time components), specified as a column name or list of column names.
+* `valid_period`: Name of the model column indicating the period for which the record is considered to be valid. The datatype must be `PERIOD(DATE)` or `PERIOD(TIMESTAMP)`. 
+* `use_valid_to_time`: Wether the end bound value of the valid period in the input is considered by the strategy when building the valid timeline. Use 'no' if you consider your record to be valid until changed (and supply any value greater to the begin bound for the end bound of the period - a typical convention is `9999-12-31` of ``9999-12-31 23:59:59.999999`). Use 'yes' if you know until when the record is valid (typically this is a correction in the history timeline).


Suggested change

* `use_valid_to_time`: Wether the end bound value of the valid period in the input is considered by the strategy when building the valid timeline. Use 'no' if you consider your record to be valid until changed (and supply any value greater to the begin bound for the end bound of the period - a typical convention is `9999-12-31` of ``9999-12-31 23:59:59.999999`). Use 'yes' if you know until when the record is valid (typically this is a correction in the history timeline).

* `use_valid_to_time`: Whether the end bound value of the valid period in the input is considered by the strategy when building the valid timeline. Use `no` if you consider your record to be valid until changed (and supply any value greater to the begin bound for the end bound of the period. A typical convention is `9999-12-31` of ``9999-12-31 23:59:59.999999`). Use `yes` if you know until when the record is valid (typically this is a correction in the history timeline).

mirnawong1 · 2024-12-13T11:56:20Z

website/docs/reference/resource-configs/teradata-configs.md

-* Identify and adjust overlapping time slices:
-  * Overlapping time periods in the data are detected and corrected to maintain a consistent and non-overlapping timeline.
-* Manage records needing to be overwritten or split based on the source and target data:
+  * The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated.


Suggested change

* The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated.

* The process of removing primary key duplicates (two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model). Full-row duplicates are always de-duplicated.

mirnawong1 · 2024-12-13T11:57:10Z

website/docs/reference/resource-configs/teradata-configs.md

+  * The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated.
+* Identify and adjust overlapping time slices (if use_valid_to_time='yes):
+  * Overlapping time periods in the data are corrected to maintain a consistent and non-overlapping timeline. To do so, the valid period end bound of a record is adjusted to meet the begin bound of the next record with the same `unique_key` value and overlapping `valid_period` value if any.
+* Manage records needing to be adjusted, deleted or split based on the source and target data:


Suggested change

* Manage records needing to be adjusted, deleted or split based on the source and target data:

* Manage records needing to be adjusted, deleted, or split based on the source and target data:

mirnawong1 · 2024-12-13T11:57:29Z

website/docs/reference/resource-configs/teradata-configs.md

-* Utilize the TD_NORMALIZE_MEET function to compact history:
-  * This function helps to normalize and compact the history by merging adjacent time periods, improving the efficiency and performance of the database.
+* Compact history:
+  * Normalize and compact the history by merging records of adjacent time periods withe same value, optimizing database storage and performance. We use the function TD_NORMALIZE_MEET for this purpose.


Suggested change

* Normalize and compact the history by merging records of adjacent time periods withe same value, optimizing database storage and performance. We use the function TD_NORMALIZE_MEET for this purpose.

* Normalize and compact the history by merging records of adjacent time periods with the same value, optimizing database storage and performance. We use the function TD_NORMALIZE_MEET for this purpose.

mirnawong1

hey @tallamohan , thanks for opening this pr up! i've made some suggestions adn couldn't commit them myself unfortunately. could you make those changes on your end and when it's ready, give me a tag and i'll look it over again?

amychen1776 · 2024-12-13T13:30:50Z

website/docs/docs/core/connect-data-platform/teradata-setup.md

+For every subsequent connection, a new browser tab briefly opens, displaying the message "TERADATA BROWSER AUTHENTICATION COMPLETED," and silently reuses the existing session.<br>
+However, the focus stays on the browser window, so you’ll need to manually switch back to the dbt console each time.<br>
+This behavior is the default functionality of the teradatasql driver and cannot be avoided at this time.<br>
+To prevent session expiration and the need to re-enter credentials, ensure the authentication browser window stays open until the job is complete.


This is not a great user experience. Do you have plans to provide caching and if so, can it be called out?

amychen1776 · 2024-12-13T13:31:41Z

website/docs/docs/core/connect-data-platform/teradata-setup.md

@@ -95,7 +95,6 @@ Parameter               | Default     | Type           | Description
 `browser_tab_timeout`   |   `"5"`     | quoted integer | Specifies the number of seconds to wait before closing the browser tab after Browser Authentication is completed. The default is 5 seconds. The behavior is under the browser's control, and not all browsers support automatic closing of browser tabs.
 `browser_timeout`       |   `"180"`   | quoted integer | Specifies the number of seconds that the driver will wait for Browser Authentication to complete. The default is 180 seconds (3 minutes).
 `column_name`           | `"false"`   | quoted boolean | Controls the behavior of cursor `.description` sequence `name` items. Equivalent to the Teradata JDBC Driver `COLUMN_NAME` connection parameter. False specifies that a cursor `.description` sequence `name` item provides the AS-clause name if available, or the column name if available, or the column title. True specifies that a cursor `.description` sequence `name` item provides the column name if available, but has no effect when StatementInfo parcel support is unavailable.
-`connect_failure_ttl`   | `"0"`       | quoted integer | Specifies the time-to-live in seconds to remember the most recent connection failure for each IP address/port combination. The driver subsequently skips connection attempts to that IP address/port for the duration of the time-to-live. The default value of zero disables this feature. The recommended value is half the database restart time. Equivalent to the Teradata JDBC Driver `CONNECT_FAILURE_TTL` connection parameter.


Did you remove this functionality? If so it might be worth calling that out to avoid confusion

Updated setup and config pages

b61d83a

tallamohan requested review from dataders and a team as code owners December 3, 2024 09:33

github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Dec 3, 2024

mirnawong1 reviewed Dec 9, 2024

View reviewed changes

website/docs/docs/core/connect-data-platform/teradata-setup.md Outdated Show resolved Hide resolved

mirnawong1 reviewed Dec 9, 2024

View reviewed changes

website/docs/reference/resource-configs/teradata-configs.md Outdated Show resolved Hide resolved

Update website/docs/docs/core/connect-data-platform/teradata-setup.md

53e9f07

Co-authored-by: Mirna Wong <[email protected]>

Update website/docs/reference/resource-configs/teradata-configs.md

5b17cf4

Co-authored-by: Mirna Wong <[email protected]>

vercel bot had a problem deploying to Preview December 10, 2024 01:38 Failure

tallamohan requested a review from mirnawong1 December 12, 2024 05:24

mirnawong1 requested a review from amychen1776 December 13, 2024 11:46

mirnawong1 reviewed Dec 13, 2024

View reviewed changes

amychen1776 reviewed Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated according to dbt-teradata 1.8.2 #6577

updated according to dbt-teradata 1.8.2 #6577

tallamohan commented Dec 3, 2024

vercel bot commented Dec 3, 2024

vercel bot commented Dec 10, 2024 •

edited

Loading

mirnawong1 commented Dec 13, 2024

mirnawong1 Dec 13, 2024

amychen1776 Dec 13, 2024

mirnawong1 Dec 13, 2024

mirnawong1 Dec 13, 2024

mirnawong1 Dec 13, 2024

mirnawong1 Dec 13, 2024

mirnawong1 Dec 13, 2024 •

edited

Loading

mirnawong1 Dec 13, 2024

mirnawong1 Dec 13, 2024

mirnawong1 left a comment

amychen1776 Dec 13, 2024

amychen1776 Dec 13, 2024

	If not specified the code defaults to using `GLOBAL_FUNCTIONS.hash_md5`. See below instructions on how to install the custom UDF:
	If not specified the code defaults to using `GLOBAL_FUNCTIONS.hash_md5`. See the following instructions on how to install the custom UDF:

		@@ -241,6 +247,14 @@ dbt-teradata 1.8.0 and later versions support unit tests, enabling you to valida

		## Limitations

		### Browser Authentication

	* For detailed guidance, refer to the dbt documentation.
	* For detailed guidance, refer to the [dbt unit tests documentation](/docs/build/documentation).

	* The process of removing primary key duplicates (ie. two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model) is retained. Full-row duplicates are always de-duplicated.
	* The process of removing primary key duplicates (two or more records with the same value for the `unique_key` and BEGIN() bond of the `valid_period` fields) in the dataset produced by the model. If such duplicates exist, the row with the lowest value is retained for all non-primary-key fields (in the order specified in the model). Full-row duplicates are always de-duplicated.

	* Manage records needing to be adjusted, deleted or split based on the source and target data:
	* Manage records needing to be adjusted, deleted, or split based on the source and target data:

	* Normalize and compact the history by merging records of adjacent time periods withe same value, optimizing database storage and performance. We use the function TD_NORMALIZE_MEET for this purpose.
	* Normalize and compact the history by merging records of adjacent time periods with the same value, optimizing database storage and performance. We use the function TD_NORMALIZE_MEET for this purpose.

updated according to dbt-teradata 1.8.2 #6577

Are you sure you want to change the base?

updated according to dbt-teradata 1.8.2 #6577

Conversation

tallamohan commented Dec 3, 2024

What are you changing in this pull request and why?

vercel bot commented Dec 3, 2024

vercel bot commented Dec 10, 2024 • edited Loading

mirnawong1 commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mirnawong1 Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mirnawong1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Dec 10, 2024 •

edited

Loading

mirnawong1 Dec 13, 2024 •

edited

Loading